Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools_scm for easier version handling #43

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

blueyed
Copy link
Member

@blueyed blueyed commented Jun 30, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2018

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files          16       15    -1     
  Lines        1516     1516           
  Branches      166      166           
=======================================
  Hits         1476     1476           
  Misses         27       27           
  Partials       13       13
Flag Coverage Δ
#py27 97.09% <100%> (ø) ⬆️
#py34 95.71% <100%> (ø) ⬆️
#py35 96.56% <100%> (ø) ⬆️
#py36 96.56% <100%> (ø) ⬆️
Impacted Files Coverage Δ
tests/test_cli.py 100% <100%> (ø) ⬆️
covimerage/cli.py 94.53% <100%> (-0.05%) ⬇️
covimerage/__init__.py 91.57% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdc25d...0e3ed09. Read the comment docs.

@@ -695,3 +694,16 @@ def test_run_report_without_data(tmpdir, runner, devnull):
'Parsing profile file %s.' % devnull.name,
'Error: No data to report.']
assert result.exit_code == 1


@pytest.importorskip('setuptools_scm')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importorskip is NOT a mark, using it like it was will result in strange issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueyed blueyed merged commit c8461d9 into Vimjas:master Jul 8, 2018
@blueyed blueyed deleted the setuptools-scm branch July 8, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants