improvement: Detect objects with main class in scripts #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
detect-mains-inscript
branch
2 times, most recently
from
36f1ef9 to
e6fae5c
Compare
Gedochao
requested changes
Feb 10, 2025
There was a problem hiding this comment.
I like the solution itself, especially as it solves a lot of use cases, even though it doesn't solve the problem fully. I left some comments on how I think we could improve this.
In the context of #3473, it's perhaps good to point out that this only fixes things for objects with a main method, but not for @main annotated methods which are top-level.
cc @philwalk, in case you have any thoughts on this.
modules/build/src/main/scala/scala/build/internal/WrapperUtils.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/internal/ClassCodeWrapper.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Outdated
Show resolved
Hide resolved
Gedochao
added
the
needs-minor-release
The object.main() approach provides a migration format that works with all scala versions, so I don't think supporting |
tgodzik
force-pushed
the
detect-mains-inscript
branch
from
e6fae5c to
4793fd8
Compare
Prebiously, if user had a legacy script with main method then it would not be picked up at all. Now, when we detect the correct signature we try to run it. This will work in case of `def main..` and when object extends App The possibility of false positives is pretty low, since user would have to have their own App, String or Array types. We will also only use that object if there are no toplevel statements
tgodzik
force-pushed
the
detect-mains-inscript
branch
from
4793fd8 to
8812c89
Compare
Gedochao
approved these changes
Feb 13, 2025
modules/build/src/main/scala/scala/build/internal/util/WarningMessages.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/internal/WrapperUtils.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #3473