Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radar to visual editor #316

Merged
merged 9 commits into from
Aug 1, 2024
Merged

Add Radar to visual editor #316

merged 9 commits into from
Aug 1, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves #311

@vitPinchuk vitPinchuk self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (9894def) to head (804d4f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   97.14%   97.82%   +0.67%     
==========================================
  Files          34       44      +10     
  Lines         455      597     +142     
  Branches       86      114      +28     
==========================================
+ Hits          442      584     +142     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 31, 2024
@mikhail-vl mikhail-vl changed the title Radar support add to visual editor Add Radar to visual editor Jul 31, 2024
@mikhail-vl mikhail-vl added this to the Charts 6.2.0 milestone Jul 31, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit e87e5cd into main Aug 1, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/radar-visual-editor branch August 1, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Radar example to use Visual Editor
3 participants