-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added drop-in replacement, code optimization, improved setup & assemb… #555
Conversation
It might be a good idea to pull the config files out into a separate git repo and just link to it from the readme fie, so that you don't have to make PRs and wait for them to get merged every time you change the config. |
Yeah I guess I can be a pain. Sorry about that, and to be honest I'm not
even sure I understand what you mean :P I'll do some research, sorry for
the inconvenience. Have a nice day!
Le mar. 28 déc. 2021, à 16 h 40, cbc02009 ***@***.***> a
écrit :
… It might be a good idea to pull the config files out into a separate git
repo and just link to it from the readme fie, so that you don't have to
make PRs and wait for them to get merged every time you change the config.
—
Reply to this email directly, view it on GitHub
<#555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQWHJPAWL3LBMBVEGBRMJW3UTIVDHANCNFSM5KZJ42EQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No, I was just trying to save you some work. Check out the klicky probe here: https://github.com/VoronDesign/VoronUsers/tree/master/printer_mods/JosAr/Klicky-Probe#step-6-klipper-configuration-dockundock-macro . the author keeps the STLs and instructions in the usermods repo, but then points the user to a different repo for the config, so he can update it whenever he wants. I thought this might save you a lot of work. |
I wanted to say thanks for your help. I did what you asked me to and did
some changes since last pull request and I think it should be good to go
now.
Do you want me to do another pull request or you'll be able to figure it
out?
If you have any questions please ask. Thanks again!
Le mar. 28 déc. 2021, à 17 h 47, cbc02009 ***@***.***> a
écrit :
… No, I was just trying to save you some work. Check out the klicky probe
here:
https://github.com/VoronDesign/VoronUsers/tree/master/printer_mods/JosAr/Klicky-Probe#step-6-klipper-configuration-dockundock-macro
. the author keeps the STLs and instructions in the usermods repo, but then
points the user to a different repo for the config, so he can update it
whenever he wants. I thought this might save you a lot of work.
—
Reply to this email directly, view it on GitHub
<#555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQWHJPCGG6UY6LF5WTGQG4DUTI5A5ANCNFSM5KZJ42EQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…ly guides
folder. Printable mods go to
printer_mods/
, firmware configurationsgo to
firmware_configurations/
, slicer profiles go toslicer_profiles/
.Create a subfolder with your name, and place the mods in a subfolder with
a descriptive name within that folder, e.g.:
/printer_mods/FHeilmann/flux_capacitor
do not contain any spaces.
README.md
file to its folder with a short descriptionof what the mod accomplishes. This readme can be used to add pictures, give assembly
instructions or specify a bill of materials if the mod requires additional hardware.
README.md
of the category folder adding thecontribution to the table. Read the top part of the file for instructions on how
to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
to fill out the compatibility matrix to indicate which versions of the Voron printer
the submission is compatible with.
and/or other Voron users. Make sure to add information about how the mod was tested below.
or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
which only modifies a few values). (When in doubt, contact one of the admins in the
Voron discord before submitting the PR)
join the Voron discord and ask the other users for advice on how to modify the mod such
that it does not require supports)
and checking if mesh errors are reported.)
Which mods/configurations/profiles are added by this PR?
Quickdraw probe for VSW
How was it tested?
By me and many others
Any background context you want to provide?
Updated some files since original pull request. Seems you wanted me to update with original VoronUsers before doing another pull request, so did it the lazy way (I don't know much about GitHub sorry)
Screenshots (if appropriate)
None
Further notes
Added drop-in replacement, code optimization, improved setup & assembly guides