Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added drop-in replacement, code optimization, improved setup & assemb… #555

Merged
merged 25 commits into from
Dec 31, 2021

Conversation

hymness1
Copy link
Contributor

…ly guides

  • [x ] The mod, firmware configuration or slicer profile is in the correct category
    folder. Printable mods go to printer_mods/, firmware configurations
    go to firmware_configurations/, slicer profiles go to slicer_profiles/.
    Create a subfolder with your name, and place the mods in a subfolder with
    a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • [x ] Folders names MUST NOT contain spaces. If possible, make sure file names also
    do not contain any spaces.
  • [x ] For each mod, add a small README.md file to its folder with a short description
    of what the mod accomplishes. This readme can be used to add pictures, give assembly
    instructions or specify a bill of materials if the mod requires additional hardware.
  • [x ] The PR modifies the top-level README.md of the category folder adding the
    contribution to the table. Read the top part of the file for instructions on how
    to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
    to fill out the compatibility matrix to indicate which versions of the Voron printer
    the submission is compatible with.
  • [x ] The mod/configuration/profile has been tested by the person submitting the mod
    and/or other Voron users. Make sure to add information about how the mod was tested below.
  • [x ] The mod is not merely a slight modification of an official Voron part, configuration
    or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
    which only modifies a few values). (When in doubt, contact one of the admins in the
    Voron discord before submitting the PR)
  • [x ] Submitted STLs are printable without support. (If the mod does not meet this criterion
    join the Voron discord and ask the other users for advice on how to modify the mod such
    that it does not require supports)
  • [x ] Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer
    and checking if mesh errors are reported.)
  • [x ] Submitted STL files are oriented and scaled properly for printing.
  • [x ] Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

Quickdraw probe for VSW

How was it tested?

By me and many others

Any background context you want to provide?

Updated some files since original pull request. Seems you wanted me to update with original VoronUsers before doing another pull request, so did it the lazy way (I don't know much about GitHub sorry)

Screenshots (if appropriate)

None

Further notes

Added drop-in replacement, code optimization, improved setup & assembly guides

@cbc02009
Copy link
Contributor

It might be a good idea to pull the config files out into a separate git repo and just link to it from the readme fie, so that you don't have to make PRs and wait for them to get merged every time you change the config.

@hymness1
Copy link
Contributor Author

hymness1 commented Dec 28, 2021 via email

@cbc02009
Copy link
Contributor

No, I was just trying to save you some work. Check out the klicky probe here: https://github.com/VoronDesign/VoronUsers/tree/master/printer_mods/JosAr/Klicky-Probe#step-6-klipper-configuration-dockundock-macro . the author keeps the STLs and instructions in the usermods repo, but then points the user to a different repo for the config, so he can update it whenever he wants. I thought this might save you a lot of work.

@hymness1
Copy link
Contributor Author

hymness1 commented Dec 28, 2021 via email

@cbc02009 cbc02009 merged commit 5719e86 into VoronDesign:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants