This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Check taxonomies exist before trying to set properties #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where a develop has unregistered the post_tag / category taxonomy, it currently procudes PHP Notices.
|
@WP-API/amigos #reviewmerge |
I'll refrain from commenting about this ;) |
|
@WP-API/amigos anyone know why codecov fails? |
|
@danielbachhuber Because there's no specific testing for this code, so it's not marked as covered. ( |
|
@WP-API/amigos #reviewmerge plz |
rmccue
added a commit
that referenced
this pull request
Jul 23, 2015
Check taxonomies exist before trying to set properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where a develop has unregistered the post_tag / category taxonomy,
it currently produces PHP Notices.