Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

If not namespace is provided, don't create double slashes #1355

Merged
merged 3 commits into from
Aug 7, 2015

Conversation

joehoyle
Copy link
Member

In cases where I'm writing a full bespoke/whitelabelled API rather than adding to WordPress's routes, or them even being available, I want to not use namespaces at all.

This is probably controversial - but point being I want my api at myserviers.com/api for better or worse. (In this specific case I'm migrating from another API system, so I need the URLs to match the old ones as it's a drop in replacement).

In this case, it's pretty easy for us to support this by just checking if a namespace was not-empty and don't add the double slashes if so.

@rmccue
Copy link
Member

rmccue commented Jun 17, 2015

I'd probably rather do a _doing_it_wrong, butttt I dunno.

@rachelbaker
Copy link
Member

I feel like this allows registered routes to skirt around namespacing their routes too easily, which is something we want to avoid. I agree with @rmccue that we should probably display a debug message.

@rmccue
Copy link
Member

rmccue commented Jun 17, 2015

Thought: _doing_it_wrong in register_rest_route, but allow it inside WP_REST_Server::register_route.

@rachelbaker rachelbaker added this to the 2.0 Beta 4 milestone Jul 5, 2015
@joehoyle
Copy link
Member Author

joehoyle commented Aug 7, 2015

Given the incorrect usage capture here, I'm ok with the tests at 60% given calling it will cause a notice anyway and fail the tests!

joehoyle added a commit that referenced this pull request Aug 7, 2015
If not namespace is provided, don't create double slashes
@joehoyle joehoyle merged commit d1d1cd2 into develop Aug 7, 2015
@joehoyle joehoyle deleted the no-namespace branch August 7, 2015 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants