Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove range assertions in BinaryReader #1416

Merged
merged 1 commit into from
May 12, 2020
Merged

Remove range assertions in BinaryReader #1416

merged 1 commit into from
May 12, 2020

Conversation

binji
Copy link
Member

@binji binji commented May 11, 2020

These assertions check to see whether the sig_index (i.e. the function
type) are in bounds. But this is the responsibility of the validator,
not the binary reader.

Fixes issues #1413 and #1414.

@binji
Remove range assertions in BinaryReader
ce1e496 
These assertions check to see whether the `sig_index` (i.e. the function
type) are in bounds. But this is the responsibility of the validator,
not the binary reader.

Fixes issues #1413 and #1414.
@binji binji requested a review from sbc100 May 11, 2020 16:45
@binji binji merged commit 28af342 into master May 12, 2020
@binji binji deleted the issue-1413-call-indirect-fix branch May 12, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 Awaiting requested review from sbc100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@binji