This repository was archived by the owner on Sep 12, 2021. It is now read-only.
Ports New Procedural Generation of Lavaland #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSuckerberg
force-pushed
the
lavaland-gen-refactor-port
branch
from
3caf7c3 to
1d647ab
Compare
-bitfielded a bunch of bools on /area, I left some untouched cus they get called a lot -Unused vars -Fixed a var pretending to be a fake bool -Probably more
…l (#54915) This replaces lavaland's old diagonal tunnel gen which was really horrendously jammed into asteroid floor code (?????) with Cellular Automata which runs in rust (PR for that here: tgstation/rust-g#57 ). The new code is a bit cleaner, but also looks better. VID: https://streamable.com/a45ke2 Things to do: - Make an icemoon version - Fix the roundstart atmos adjacency issues I asked AnturK if this was an acceptable PR for this month; he said it was okay as long as I didn't add new areas, which I don't plan to do. But if anyone thinks this PR breaks the spirit of the month I'll open it again in december.
MarkSuckerberg
force-pushed
the
lavaland-gen-refactor-port
branch
from
1d647ab to
550bc21
Compare
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Superyodeler
approved these changes
Dec 26, 2020
Whitesands-Bot
added a commit
that referenced
this pull request
Dec 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports:
tgstation/tgstation#52751
tgstation/tgstation#54915
tgstation/tgstation#55462
Why It's Good For The Game
Makes lavaland's tunnels much more interesting and natural looking, rather than just boring diagonal holes.
(Vid from original PR: https://streamable.com/a45ke2)
Changelog
🆑 Qustinnus, TiviPlus
refactor: refactored a bunch of /area stuff
code: Lavaland is no longer generated in broken diagonals, instead utilizing a map_generator datum.
code: Bunch of unused turf paths removed
/:cl: