WP-5737 over_react should follow new logger name standard #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 33 33
Lines 1591 1591
=======================================
Hits 1504 1504
Misses 87 87 |
greglittlefield-wf
approved these changes
Jan 10, 2018
jacehensley-wf
approved these changes
Jan 10, 2018
|
QA +1
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename loggers to follow the pattern:
<package_name>.<class_name>per @leerobinson-wf's email to wf-dev.Testing/QA
Code Review
@Workiva/app-frameworks