Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-3039 Get rid of dart2js compiler warnings #137

Merged
merged 3 commits into from
Feb 15, 2018

Conversation

aaronlademann-wf
Copy link
Contributor

Ultimate problem:

A few pieces of our code was causing noisy dart2js compiler output for our consumers.

How it was fixed:

Address those items.

Testing suggestions:

Passing CI build

Potential areas of regression:

None expected.


FYA: @Workiva/app-frameworks

+ Silences the dart2js warning about missing impl
+ To prevent dupe library name warnings for consumer dart2js builds
@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner February 14, 2018 17:54
@aviary2-wf
Copy link

Raven

Number of Findings: 0

Magpie

Number of findings: 0

@codecov-io
Copy link

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          33       33           
  Lines        1591     1591           
=======================================
  Hits         1504     1504           
  Misses         87       87

@rmconsole-wf rmconsole-wf changed the title Get rid of dart2js compiler warnings UIP-3039 Get rid of dart2js compiler warnings Feb 14, 2018
@jayudey-wf
Copy link
Contributor

jayudey-wf commented Feb 15, 2018

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Security review (if required)
  • Unit tests created/updated (n/a dart2js updates)
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in
  • Areas of regression noted

Merging into master.

@jayudey-wf
Copy link
Contributor

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants