Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build #179

Merged
merged 1 commit into from
Sep 10, 2018
Merged

update build #179

merged 1 commit into from
Sep 10, 2018

Conversation

josephswanson-wf
Copy link
Contributor

Ultimate problem:

  • utilizing a 6gb image to do core dart things

How it was fixed:

  • leverage google/dart image
  • update version in travis
  • remove smithy.yaml
  • cleanup unneeded args

Testing suggestions:

  • ensure CI passes
  • basic regression testing

Potential areas of regression:

  • CI
  • ?

FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf @jeffhall-wk @bradbenjamin-wf

@josephswanson-wf josephswanson-wf requested a review from a team as a code owner September 7, 2018 21:03
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

aaronlademann-wf
aaronlademann-wf approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

The travis failure is a pinned dependency failure that has been fixed in master.

@aaronlademann-wf
Copy link
Contributor

@Workiva/release-management-pp

@aaronlademann-wf aaronlademann-wf merged commit 54a3b15 into Workiva:master Sep 10, 2018
@aaronlademann-wf aaronlademann-wf mentioned this pull request Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlademann-wf aaronlademann-wf aaronlademann-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephswanson-wf @aviary2-wf @aaronlademann-wf @rmconsole-wf