Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-2719 AF-2718 Release over_react 1.28.0 #194

Merged
merged 2 commits into from
Oct 23, 2018
Merged

AF-2719 AF-2718 Release over_react 1.28.0 #194

merged 2 commits into from
Oct 23, 2018

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf requested a review from a team as a code owner October 23, 2018 20:13
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@rmconsole3-wf rmconsole3-wf changed the title Release over_react 1.28.0 AF-2719 AF-2718 Release over_react 1.28.0 Oct 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          34       34           
  Lines        1640     1640           
=======================================
  Hits         1546     1546           
  Misses         94       94

aaronlademann-wf
aaronlademann-wf approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@greglittlefield-wf
Copy link
Contributor Author

QA +1 @Workiva/release-management-pp

@rmconsole3-wf rmconsole3-wf merged commit 0101717 into master Oct 23, 2018
@rmconsole3-wf rmconsole3-wf deleted the release-1.28.0 branch October 23, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlademann-wf aaronlademann-wf aaronlademann-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready Type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@greglittlefield-wf @aviary3-wk @codecov-io @aaronlademann-wf @rmconsole-wf @rmconsole3-wf