-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AF-3870: fix webstorm and vs code snippets #224
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
======================================
Coverage 90.3% 90.3%
======================================
Files 35 35
Lines 1772 1772
======================================
Hits 1600 1600
Misses 172 172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed also need: over.react
to change to over_react
in the part file names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
Ultimate problem:
Factory initialization and props meta initialization was missing the starting
_
making the code snippets for both WebStorm and VS Code incorrect.How it was fixed:
_
on both props meta and factory initializations.Testing suggestions:
Potential areas of regression:
None