Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-3870: fix webstorm and vs code snippets #224

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

sebastianmalysa-wf
Copy link
Contributor

Ultimate problem:

Factory initialization and props meta initialization was missing the starting _ making the code snippets for both WebStorm and VS Code incorrect.

How it was fixed:

  • Add the starting _ on both props meta and factory initializations.

Testing suggestions:

  • CI passes

Potential areas of regression:

None


FYA: @kealjones-wk @evanweible-wf @corwinsheahan-wf -wf

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Lookin good :)
img_6535

@codecov-io
Copy link

Codecov Report

Merging #224 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #224   +/-   ##
======================================
  Coverage    90.3%   90.3%           
======================================
  Files          35      35           
  Lines        1772    1772           
======================================
  Hits         1600    1600           
  Misses        172     172

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed also need: over.react to change to over_react in the part file names

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@evanweible-wf
Copy link
Contributor

@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants