Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-3912 Update Dart 2 codemod references #226

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

evanweible-wf
Copy link
Contributor

Description

The name/usage of the dart2 upgrade codemod script changed slightly, so the references in the over_react dart 2 migration guide need to be updated accordingly.

Testing suggestions:

n/a

Potential areas of regression:

n/a


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@evanweible-wf evanweible-wf requested a review from a team as a code owner January 23, 2019 04:15
@evanweible-wf evanweible-wf added the dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility label Jan 23, 2019
@evanweible-wf evanweible-wf added this to the Dart 2 Compat milestone Jan 23, 2019
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@codecov-io
Copy link

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #226   +/-   ##
======================================
  Coverage    90.3%   90.3%           
======================================
  Files          35      35           
  Lines        1772    1772           
======================================
  Hits         1600    1600           
  Misses        172     172

@corwinsheahan-wf
Copy link
Contributor

QA +1

  • CI Passes (documentation change only)

Merging into master.
@Workiva/release-management-p

@rm-astro-wf rm-astro-wf merged commit 3e7d54f into master Jan 23, 2019
@rm-astro-wf rm-astro-wf deleted the update_dart2_codemod_refs branch January 23, 2019 14:20
@evanweible-wf evanweible-wf modified the milestones: Dart 2 Compat, 2.0.0 (Dart 1 & 2 compatibility) Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility Merge Requirements Met RM Ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants