Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4061 Deprecate getJsProps(), $Props, and $PropKeys. #230

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Feb 5, 2019

Fixes #213.

Description

The following APIs are being removed in v2.0.0, and consequently need to be deprecated in a 1.x release:

  • getJsProps() (use getProps() instead)
  • $Props and $PropKeys (being replaced by the static meta getters on props/state classes)

Testing suggestions:

  • CI passes

Potential areas of regression:

n/a


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @corwinsheahan-wf

@evanweible-wf evanweible-wf added the dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility label Feb 5, 2019
@evanweible-wf evanweible-wf requested a review from a team as a code owner February 5, 2019 21:41
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@codecov-io
Copy link

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files          35       35           
  Lines        1775     1775           
=======================================
  Hits         1603     1603           
  Misses        172      172

@@ -30,6 +30,9 @@ export './component_base.dart'
/// in a static yet unsafe way.
///
/// __For advanced usage only.__
///
/// __Deprecated. Will be removed in 2.0.0.__
@deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit could use @Deprecated('2.0.0')

@greglittlefield-wf
Copy link
Contributor

+10

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility Merge Requirements Met RM Ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants