CPLAT-4129: Use unconvertJsProps() instead of getJsProps()
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rmconsole7-wk
changed the title
unconvertJsProps() instead of getJsProps()unconvertJsProps() instead of getJsProps()
charliekump-wf
changed the title
unconvertJsProps() instead of getJsProps()unconvertJsProps() instead of getJsProps()
|
Failing build is expected, will be fixed when react-dart 4.6.0 has actually be released. |
|
+1 |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 90.31% 90.24% -0.07%
==========================================
Files 35 35
Lines 1775 1771 -4
==========================================
- Hits 1603 1598 -5
- Misses 172 173 +1 |
|
QA +1 All tests passed in CI. @Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPLAT-4129
This is dependent on Workiva/react-dart#153 - should be released in
react-dart v4.6.0Ultimate problem:
getJsProps()is deprecated and the alternative (unconvertJsProps()) is available in react-dart 4.6.0.How it was fixed:
Update usages of the deprecated
getJsProps()to the newunconvertJsProps()method in react-dart.Testing suggestions:
Potential areas of regression:
getJsProps(), should all be tested via unit tests