Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-5632 Downgrade parse error to fine so as to not fail build unnecessarily #288

Merged
merged 2 commits into from
May 3, 2019

Conversation

greglittlefield-wf
Copy link
Contributor

Motivation

Syntax errors in the example dir cause the OverReact builder to unexpectedly fail the build when running pbr test

For example:

$ pbr test -- test/foo_test.dart
[INFO] Generating build script completed, took 329ms
[INFO] Reading cached asset graph completed, took 548ms
[INFO] Checking for updates since last build completed, took 973ms
[INFO] Running build completed, took 404ms
[INFO] Caching finalized dependency graph completed, took 301ms
[SEVERE] over_react:overReactBuilder on example/viewport/main.dart (cached):
There was an error parsing the compilation unit for file: w_virtual_components|example/viewport/main.dart

Changes

Downgrade parse error to fine so as to not fail build unnecessarily

If they're problematic, these errors will be handled further
down the line (e.g., build_web_compilers).

This prevents syntax errors in examples from failing test
compilation.

Release Notes

  • Avoid failing the build unnecessarily due to parse errors

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

If they're problematic, these errors will be handled further
down the line (e.g., build_web_compilers).

This prevents syntax errors in examples from failing test
compilation.
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf greglittlefield-wf marked this pull request as ready for review April 30, 2019 20:37
@rmconsole7-wk rmconsole7-wk changed the title Downgrade parse error to fine so as to not fail build unnecessarily CPLAT-5632 Downgrade parse error to fine so as to not fail build unnecessarily May 3, 2019
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

  • Tests pass
  • Local pbr build in repo mentioned by author now passes

@Workiva/release-management-pp

@rmconsole7-wk rmconsole7-wk merged commit e1bcc8a into master May 3, 2019
@rmconsole7-wk rmconsole7-wk deleted the greglittlefield-wf-patch-2 branch May 3, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants