-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-1053 Cancel the transitionend timer when AbstractTransitionComponent unmounts #294
Merged
rmconsole5-wk
merged 1 commit into
1.x_release_base
from
CPLAT-1053_cancel-transitionend-timer
May 15, 2019
Merged
CPLAT-1053 Cancel the transitionend timer when AbstractTransitionComponent unmounts #294
rmconsole5-wk
merged 1 commit into
1.x_release_base
from
CPLAT-1053_cancel-transitionend-timer
May 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Codecov Report
@@ Coverage Diff @@
## 1.x_release_base #294 +/- ##
====================================================
+ Coverage 90.27% 90.27% +0.01%
====================================================
Files 36 36
Lines 1807 1808 +1
====================================================
+ Hits 1631 1632 +1
Misses 176 176 |
cb66d4f
to
a0615f6
Compare
+1 |
a0615f6
to
70ee2c3
Compare
+1 |
9eec1a9
to
3855a3a
Compare
70ee2c3
to
8558066
Compare
+ To prevent ReactJS setState warnings involving unmounted components
8558066
to
f8dd17f
Compare
joebingham-wk
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
QA +1 @Workiva/release-management-pp |
This was referenced May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ReactJS
setState
warnings are being produced by components that extend fromAbstractTransitionComponent
.Changes
Cancel the
transitionend
timer in-addition-to the subscription withincomponentWillUnmount
.Release Notes
Fix issue that causes ReactJS
setState
warnings to appear in the browser console.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: