Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-1053 Cancel the transitionend timer when AbstractTransitionComponent unmounts #294

Merged

Conversation

aaronlademann-wf
Copy link
Contributor

  • To prevent ReactJS setState warnings involving unmounted components

Motivation

ReactJS setState warnings are being produced by components that extend from AbstractTransitionComponent.

Changes

Cancel the transitionend timer in-addition-to the subscription within componentWillUnmount.

Release Notes

Fix issue that causes ReactJS setState warnings to appear in the browser console.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review: @greglittlefield-wf

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #294 into 1.x_release_base will increase coverage by 0.01%.
The diff coverage is 100%.

@@                 Coverage Diff                  @@
##           1.x_release_base     #294      +/-   ##
====================================================
+ Coverage             90.27%   90.27%   +0.01%     
====================================================
  Files                    36       36              
  Lines                  1807     1808       +1     
====================================================
+ Hits                   1631     1632       +1     
  Misses                  176      176

@aaronlademann-wf aaronlademann-wf force-pushed the CPLAT-1053_cancel-transitionend-timer branch from cb66d4f to a0615f6 Compare May 15, 2019 21:55
@greglittlefield-wf
Copy link
Contributor

+1

@aaronlademann-wf aaronlademann-wf force-pushed the CPLAT-1053_cancel-transitionend-timer branch from a0615f6 to 70ee2c3 Compare May 15, 2019 22:08
@greglittlefield-wf
Copy link
Contributor

+1

@aaronlademann-wf aaronlademann-wf force-pushed the CPLAT-1053_cancel-transitionend-timer branch from 70ee2c3 to 8558066 Compare May 15, 2019 22:23
+ To prevent ReactJS setState warnings involving unmounted components
@aaronlademann-wf aaronlademann-wf force-pushed the CPLAT-1053_cancel-transitionend-timer branch from 8558066 to f8dd17f Compare May 15, 2019 22:34
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Contributor Author

QA +1

@Workiva/release-management-pp

@rmconsole5-wk rmconsole5-wk merged commit f1cb674 into 1.x_release_base May 15, 2019
@rmconsole5-wk rmconsole5-wk deleted the CPLAT-1053_cancel-transitionend-timer branch May 15, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants