-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-7471 Refactor Prop Type Tests #433
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise just formatting nits.
I love these matchers so much 😻
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
Co-Authored-By: Greg Littlefield <[email protected]>
…s/component2/required_accessor_integration_test.dart Co-Authored-By: Greg Littlefield <[email protected]>
…va/over_react into CPLAT-7471-refactor-propType-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Nice work here @joebingham-wk !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
Motivation
The prop type tests for over_react were still using the outdated
propType
testing methods. Refactoring the tests keeps them up to date with the latest APIs and helps provide examples of how to use our testing utils.Changes
propTypes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@kealjones-wk @greglittlefield-wf @sydneyjodon-wk @aaronlademann-wf
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: