Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-8863 Remove Dart 2.4 from CI #442

Merged
merged 3 commits into from
Dec 12, 2019
Merged

CPLAT-8863 Remove Dart 2.4 from CI #442

merged 3 commits into from
Dec 12, 2019

Conversation

kealjones-wk
Copy link
Contributor

@kealjones-wk kealjones-wk commented Dec 12, 2019

Motivation

Dart 2.4 and I do not get along.

Changes

  • Threw Dart 2.4 to the curb in .travis.yaml
  • Updated dockerfile to use google/dart:2.6

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole6-wk rmconsole6-wk changed the title Remove Dart 2.4 from CI CPLAT-8863 Remove Dart 2.4 from CI Dec 12, 2019
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@kealjones-wk
Copy link
Contributor Author

@Workiva/release-management-p

@rm-astro-wf rm-astro-wf merged commit 8e35199 into master Dec 12, 2019
@rm-astro-wf rm-astro-wf deleted the no-more-dart-2.4 branch December 12, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants