Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare quiver as a direct dependency #45

Conversation

jacehensley-wf
Copy link
Contributor

Ultimate problem:

quiver only a transitive dev dependency but it is used within lib/.

How it was fixed:

  • Declare quiver as a direct dependency.

Testing suggestions:

N/A

Potential areas of regression:

N/A


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

Current coverage is 97.42% (diff: 100%)

Merging #45 into master will not change coverage

@@             master        #45   diff @@
==========================================
  Files            28         28          
  Lines          1316       1316          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1282       1282          
  Misses           34         34          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update bb39096...96954db

@aaronlademann-wf
Copy link
Contributor

+1

@aaronlademann-wf
Copy link
Contributor

@leviwith-wf this is ready for you.

@jacehensley-wf
Copy link
Contributor Author

Closing as this will be done in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants