CPLAT-9092 Add built_redux to Redux Docs #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebingham-wk
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
requested changes
Jan 29, 2020
doc/built_redux_to_redux.md
Outdated
Comment on lines
51
to
66
| // Using `combineReducers` | ||
| final incrementReducer = (ReduxState prevState, IncrementAction action) => | ||
| ReduxState.from(count: prevState.count + action.incrementBy); | ||
| final decrementReducer = (ReduxState prevState, DecrementAction action) => | ||
| ReduxState.from(count: prevState.count - action.decrementBy); | ||
| final customActionReducer = (ReduxState prevState, CustomAction action) => | ||
| ReduxState.from(customActionValue: action.customActionValue, secondCustomActionValue: action.seconCusomActionValue); | ||
| final simpleActionReducer = (ReduxState prevState, SimpleAction action) => | ||
| ReduxState.from(simpleActionState: !prevState.simpleActionState); | ||
|
|
||
| Reducer<ReduxState> countReducer = combineReducers([ | ||
| TypedReducer<ReduxState, IncremementAction>(incrementReducer), | ||
| TypedReducer<ReduxState, DecrementAction>(decrementReducer), | ||
| TypedReducer<ReduxState, CustomAction>(customActionReducer), | ||
| TypedReducer<ReduxState, SimpleAction>(simpleActionReducer), | ||
| ]); |
There was a problem hiding this comment.
Is there a reason we're using more reducers than the built_redux example has? Shouldn't we just do increment / decrement for parity?
There was a problem hiding this comment.
Yep, good catch. The reason they were all there was that combineReducers used to be part of the the Reducer section below, but then I moved it into its own section and just grabbed the ReducerBuilder example. So no real reason.
Co-Authored-By: Aaron Lademann <[email protected]>
…2-builtRedux-to-Redux
aaronlademann-wf
approved these changes
Jan 29, 2020
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To aid in the transition to Redux, we want to add a doc that outlines the differences between built_redux and Redux, along with tips on how to transition.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@aaronlademann-wf @greglittlefield-wf @willdrach-wk @sydneyjodon-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: