CPLAT-9691 Improve HOC Errors #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebingham-wk
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| // original Dart component via the 'WrappedComponent` property. | ||
| if (instance.type != null && getProperty(instance.type, 'WrappedComponent') != null) { | ||
| instanceType = getProperty(instance.type, 'WrappedComponent'); | ||
| } |
There was a problem hiding this comment.
Hm, I just took this out; was this a bad merge conflict, or was this added back in intentionally?
There was a problem hiding this comment.
Nope, I definitely didn't mean to add that back in. Sorry about that!
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, wrapping a
UiComponentin one of our HOC utilities (forwardRef,connect,connectFlux) will throw a cryptic error, and there's no mention of that on the utility doc comments.Changes
connect,connectFlux, andforwardRefnoting that the component being wrapped should extendComponent2.Componentis passed inRelease Notes
connect,connectFlux, andforwardReffail gracefully when an invalid component gets passed in.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@aaronlademann-wf @greglittlefield-wf @sydneyjodon-wk @willdrach-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: