Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-89097 RM-89096 Release over_react 4.0.0 #647

Merged
merged 32 commits into from
Jan 19, 2021
Merged

RM-89097 RM-89096 Release over_react 4.0.0 #647

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
58e8670
Add dependency overrides
sydneyjodon-wk Oct 16, 2020
661aa79
Add Greg's updates to event helpers
sydneyjodon-wk Oct 23, 2020
ac494f2
Update react dependency override
sydneyjodon-wk Oct 26, 2020
ae11122
Update react dependency overrides
sydneyjodon-wk Oct 26, 2020
6ef6f91
Remove fixme
sydneyjodon-wk Oct 27, 2020
f6d59e8
Fix failing test
sydneyjodon-wk Oct 27, 2020
c4a339c
Move event helper utils to react-dart
sydneyjodon-wk Nov 2, 2020
017d855
Update react overrides to 6.0.0-wip
sydneyjodon-wk Nov 4, 2020
1d91c08
Merge branch 'master' into 4.0.0-wip
sydneyjodon-wk Nov 5, 2020
a6e1e35
Point to new branch
joebingham-wk Nov 10, 2020
c89d43e
Resolve conflicts
joebingham-wk Nov 10, 2020
db598c6
Merge branch 'master' of github.com:Workiva/over_react into 4.0.0-wip
joebingham-wk Nov 17, 2020
0e75a57
Merge branch '4.0.0-wip' of github.com:Workiva/over_react into react-…
joebingham-wk Nov 17, 2020
8cc4705
Add helper
joebingham-wk Nov 17, 2020
f3996da
Add new helper
joebingham-wk Nov 18, 2020
14440ad
Remove extension export
joebingham-wk Nov 18, 2020
cd5eb93
Update overrides
joebingham-wk Nov 20, 2020
8fc3219
Update helpers
joebingham-wk Nov 20, 2020
4c44389
Address PR feedback
joebingham-wk Nov 24, 2020
350c355
Merge pull request #639 from Workiva/react-17-synthetic-event-updates
greglittlefield-wf Nov 24, 2020
03d73c8
Merge branch 'master' into 4.0.0-wip
sydneyjodon-wk Nov 24, 2020
843c1b8
over_react_4.0.0
rmconsole-readonly-wk Nov 24, 2020
7ab92bd
Add over_react_test override
joebingham-wk Nov 24, 2020
7c55759
Merge pull request #648 from Workiva/4.0.0-wip
joebingham-wk Nov 24, 2020
c21bb67
Update Changelog
joebingham-wk Nov 30, 2020
c02f25d
Point changelog to PR
joebingham-wk Dec 1, 2020
7c6cf4e
Remove over_react_test override
joebingham-wk Dec 1, 2020
acead9a
Update dependencies
joebingham-wk Dec 1, 2020
02082c2
Fix bad implicit cast in composeHocs (technically a breaking change)
greglittlefield-wf Jan 13, 2021
2bb2504
Merge branch 'master' of github.com:Workiva/over_react into release_o…
bender-wk Jan 14, 2021
54b223d
Update version in README example
aaronlademann-wf Jan 14, 2021
5b6cb62
Consume react 6.0.0
greglittlefield-wf Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/util/hoc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
/// ),
/// ])(_$BigBlock);
/// ```
R Function(A) composeHocs<R, A extends R>(Iterable<R Function(A)> functions) {
R Function(R) composeHocs<R>(Iterable<R Function(R)> functions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a bad implicit cast in the implementation and shouldn't affect consumers.

Thankfully, there are no consumers, so we know it won't affect any 😄 : https://sourcegraph.wk-dev.wdesk.org/search?q=composeHocs&patternType=literal

return functions.reduce((a, b) => (result) => a(b(result)));
}