Allow unsupported units in toRem / toPx functions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
aaronlademann-wf
force-pushed
the
rem_util-update
branch
from
6eb3fbb to
c00f6e3
Compare
Current coverage is 96.97% (diff: 100%)@@ master #7 diff @@
==========================================
Files 26 26
Lines 1186 1192 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1150 1156 +6
Misses 36 36
Partials 0 0
|
+ Since codecov is so bae as the kids would say
| expect(() => toPx(new CssValue.parse('1em')), allOf( | ||
| throwsArgumentError, | ||
| throwsA(hasToStringValue(contains('must be a num or a String rem value')))) | ||
| throwsA(hasToStringValue(contains('must be a rem num or a String px/rem value')))) | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Needs tests for passThroughUnsupportedUnits, like those for toRem.
There was a problem hiding this comment.
Is it possible that Codecov actually wasn't bae?
cfdd199
There was a problem hiding this comment.
touché greggers
|
One missing test, otherwise LGTM |
|
@greglittlefield-wf test added. |
|
+1 |
|
@leviwith-wf this is ready for merge |
QA +10 Merging |
|
RM +1 manually reviewed dependencies |
clairesarsam-wf
pushed a commit
to clairesarsam-wf/over_react
that referenced
this pull request
Jan 6, 2017
Allow unsupported units in toRem / toPx functions
greglittlefield-wf
pushed a commit
that referenced
this pull request
Jun 19, 2020
Remove entire line in fix removing dupe prop, fix unawaited futures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows consumers to begin utilizing
toRem/toPxmethods within their components - without causing breaking API changes since their consumers may have been implementing the components using a unit likeem.Mirrors WSD commit
0178ddFYA @greglittlefield-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf