Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.13.4 to matrix #708

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Add 2.13.4 to matrix #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/dart_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.7.2, stable, dev ]
sdk: [ 2.7.2, 2.13.4, stable, dev ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/[email protected]
Expand All @@ -35,7 +35,7 @@ jobs:

- name: Verify formatting
run: pub run dart_dev format --check
if: always() && ${{ matrix.sdk }} == '2.7.2' && steps.install.outcome == 'success'
if: always() && matrix.sdk == '2.7.2' && steps.install.outcome == 'success'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this since this was invalid syntax; if entries are interpolated already (which is why we can do steps.install.outcome on this same line without that interpolation), and adding interpolation within them messes things up.


# Analyze before generated files are created to verify that component boilerplate analysis is "clean" without the need for building
- name: Analyze example source (pre-build)
Expand All @@ -44,9 +44,7 @@ jobs:
# which could cause analysis issues for consumers who haven't run a build yet.
dartanalyzer lib
cd example/boilerplate_versions
if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; fi
if [ ${{ matrix.sdk }} = 'stable' ]; then echo 'Skip pre-build analysis for Dart versions >=2.9 and <2.12 because there will be analysis errors.'; fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only relevant when stable was >=2.9<2.12, so I removed it.

if [ ${{ matrix.sdk }} = 'dev' ]; then cd mixin_based/dart_2_9_compatible && dart analyze; fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have to analyze only mixin_based/dart_2_9_compatible after Dart 2.13 reinstated the ability to ignore analysis errors

if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; else dart analyze; fi
if: always() && steps.install.outcome == 'success'

- id: build
Expand Down Expand Up @@ -84,7 +82,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.7.2, stable, dev ]
sdk: [ 2.7.2, 2.13.4, stable, dev ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/[email protected]
Expand Down