CPLAT-17301 Update AriaPropsMixin #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Co-authored-by: brianphillips-wk <[email protected]>
Co-authored-by: brianphillips-wk <[email protected]>
Co-authored-by: brianphillips-wk <[email protected]>
…_react into CPLAT-17301-aria-attributes
brianphillips-wk
requested review from
brianphillips-wk
and removed request for
brianphillips-wk
brianphillips-wk
requested review from
a team and
sydneyjodon-wk
and removed request for
a team
greglittlefield-wf
requested changes
May 6, 2022
Co-authored-by: Greg Littlefield <[email protected]>
…_react into CPLAT-17301-aria-attributes
|
Looks like the build is failing on the analyzer test check, but this seems to be failing on the master branch as well. Please let me know how to go about this |
|
@sydneesampson-wk We should be able to ignore that check for now, sorry about that! |
greglittlefield-wf
approved these changes
May 9, 2022
Comment on lines
+38
to
+39
| ///See: <https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes> | ||
|
|
There was a problem hiding this comment.
For this - when "documenting" an entire page / library, we usually put them above the library directive. In this case - that is on line 15...
/// See: <https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes>
library over_react.aria_mixin;
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update AriaPropsMixin with missing attributes
Changes
Added missing Aria attributes
Added missing Aria roles
Updated outdated W3 links
Add new documentation
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: