-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIP-2379 Memory leak audit #75
Merged
greglittlefield-wf
merged 4 commits into
Workiva:master
from
aaronlademann-wf:memory-leak-audit
Jun 13, 2017
Merged
UIP-2379 Memory leak audit #75
greglittlefield-wf
merged 4 commits into
Workiva:master
from
aaronlademann-wf:memory-leak-audit
Jun 13, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
+1 |
johnbland-wf
approved these changes
Jun 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 28 28
Lines 1387 1387
======================================
Hits 1355 1355
Misses 32 32 |
+ It is abandonware. Use Workiva’s platform_detect instead.
+1 |
QA +1
Ready for merge and tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
cancel_subscriptions
andclose_sinks
lints were not enabled.AbstractTransitionComponent
/ResizeSensorComponent
both have lifecycle methods that - if a consumer were to extend from, and not callsuper
- could/would cause memory leaks.browser_detect
dev dependency is abandonware.How it was fixed:
@mustCallSuper
annotation was added to critical lifecycle methods that register handlers that could leak if never un-registered / destroyed / closed.platform_detect
instead.Testing suggestions:
Verify that tests pass
Potential areas of regression:
None expected