Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2379 Memory leak audit #75

Merged
merged 4 commits into from
Jun 13, 2017

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Jun 12, 2017

Ultimate problem:

  1. The cancel_subscriptions and close_sinks lints were not enabled.
  2. AbstractTransitionComponent / ResizeSensorComponent both have lifecycle methods that - if a consumer were to extend from, and not call super - could/would cause memory leaks.
  3. The browser_detect dev dependency is abandonware.

How it was fixed:

  1. Lints were added / instances of violations were addressed (tests were the only place that had problems)
  2. @mustCallSuper annotation was added to critical lifecycle methods that register handlers that could leak if never un-registered / destroyed / closed.
  3. Use platform_detect instead.

Testing suggestions:

Verify that tests pass

Potential areas of regression:

None expected


FYA: @Workiva/ui-platform-pp

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@aaronlademann-wf aaronlademann-wf changed the title Memory leak audit UIP-2379 Memory leak audit Jun 12, 2017
@jacehensley-wf
Copy link
Contributor

+1

Copy link

@johnbland-wf johnbland-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

codecov-io commented Jun 12, 2017

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #75   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files          28      28           
  Lines        1387    1387           
======================================
  Hits         1355    1355           
  Misses         32      32

+ It is abandonware.  Use Workiva’s platform_detect instead.
@greglittlefield-wf
Copy link
Contributor

+1

@greglittlefield-wf
Copy link
Contributor

QA +1

  • Tests Pass
  • Dev +1’s
  • Rosie ran / evaluation displays expected info
  • Dependency Scan Clean

Ready for merge and tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants