FED-1255 Add [Suspense] Component #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rmconsole7-wk
changed the title
kealjones-wk
commented
Apr 19, 2023
| /// | ||
| /// See: <https://react.dev/reference/react/Suspense> | ||
| UiFactory<SuspenseProps> Suspense = uiJsComponent( | ||
| ReactJsComponentFactoryProxy(_jsSuspense), |
There was a problem hiding this comment.
Should I wait on Workiva/react-dart#357 and use react.Suspense instead @greglittlefield-wf
kealjones-wk
requested review from
a team and
greglittlefield-wf
and removed request for
a team
greglittlefield-wf
requested changes
Apr 26, 2023
greglittlefield-wf
requested changes
Apr 27, 2023
| /// A props mixin for props specific to the [Suspense] component. | ||
| @Props(keyNamespace: '') | ||
| mixin SuspensePropsMixin on UiProps { | ||
| /*ReactNode*/ dynamic fallback; |
There was a problem hiding this comment.
A doc comment here would be nice. You could steal the one from https://react.dev/reference/react/Suspense#props
hunterbreathat-wk
previously approved these changes
Apr 27, 2023
greglittlefield-wf
requested changes
May 2, 2023
Co-authored-by: Greg Littlefield <[email protected]>
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RMUI has some "lazy" components coming in hot. We need Suspense in order to support their consumption.
Changes
SuspensecomponentRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: