Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2450 Update quiver dependency #89

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

aaronlademann-wf
Copy link
Contributor

  • DDC compilation errors are still present even in 0.24.0

FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@greglittlefield-wf
Copy link
Contributor

Shouldn't we just increase the upper bound, to help ease version lock?

@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          31       31           
  Lines        1522     1522           
=======================================
  Hits         1443     1443           
  Misses         79       79

+ DDC compilation errors are present even in 0.24.0
@greglittlefield-wf
Copy link
Contributor

+1

@aaronlademann-wf aaronlademann-wf changed the title Update quiver dependency UIP-2450 Update quiver dependency Jun 27, 2017
@leviwith-wf
Copy link
Contributor

QA +10

  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@leviwith-wf leviwith-wf merged commit 1011199 into Workiva:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants