HY-4964 Turn on strong mode and lint rules #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
robbecker-wf
changed the title
|
@charliekump-wf @evanweible-wf @davidmarne-wf someone review and merge |
evanweible-wf
approved these changes
Jun 15, 2017
| @@ -2,7 +2,7 @@ library echo; | |||
|
|
|||
| import "dart:html"; | |||
| import 'package:logging/logging.dart'; | |||
| import "package:sockjs_client/sockjs.dart" as SockJS; | |||
| import "package:sockjs_client/sockjs_client.dart" as SockJS; | |||
There was a problem hiding this comment.
Was this just straight up broken?
There was a problem hiding this comment.
it was totally the wrong path .. i think the example must not have been able to work.
evanweible-wf
approved these changes
Jun 19, 2017
trentgrover-wf
approved these changes
Jun 19, 2017
|
@jayudey-wf ready for merge and release |
|
QA +1
Merging into master. |
|
@evanweible-wf Do we need to cut a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on strong mode and add required lint rules.
Testing
I pulled this into w_transport and all tests pass
