Preparations for React 17 compatibility, fix master build #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
sourcegraph-wk
changed the title
| import 'dart:html'; | ||
|
|
||
| import 'package:over_react/components.dart' show ErrorBoundary; |
There was a problem hiding this comment.
I fixed some deprecation warnings for ErrorBoundary/setClientConfiguration while I was in here
| @@ -21,7 +21,6 @@ import 'package:http_parser/http_parser.dart' show MediaType; | |||
| import 'package:mockito/mockito.dart'; | |||
| import 'package:test/test.dart'; | |||
| import 'package:w_transport/mock.dart'; | |||
| import 'package:w_transport/src/http/auto_retry.dart'; | |||
| <head> | ||
| <title>{{testName}} Test</title> | ||
| <script> | ||
| // Workaround to Chrome 86 DDC issues: |
There was a problem hiding this comment.
This was necessary to fix tests failing in master
greglittlefield-wf
changed the title
|
This is ready for review @sydneyjodon-wk @aaronlademann-wf (for some reason I could only request review from Sydney 🤷) FYI @evanweible-wf (fixes master build) |
|
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
React 17 was released at the end of October and came with some exciting benefits. For the full list, see the ReactJS blog post.
For Workiva, upgrading so promptly is even more exciting because it:
Wdesk is currently using ReactJS
16.13.1, and the Client Platform team has been working to upgrade our Dart wrappers to be compatible with the latest major version of ReactJS (17.x). Now that major releases of thereact(6.0.0) andover_react(4.0.0) packages are ready to release, its time to begin making the entire Workiva front-end ecosystem compatible!Changes
This upgrade will be fundamentally simpler than the React 16 upgrade and will be much easier in comparison.
All changes/fixes will be handled by Client Platform before repo owners are requested for review(s).
react/over_reactdependencies to allow the new major release versions to be pulled in once all downstream dependencies are also compatible.onScrollevents no longer bubbleAdditional changes
Release Notes
Make this library compatible with ReactJS 17.
QA Instructions
References
Created by Sourcegraph campaign
Workiva/react_17_rollout.