Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

升级到 egg v4 的 esm 模式后，qps 数据丢失 #10

Closed
fengmk2 opened this issue Mar 9, 2025 · 3 comments · Fixed by X-Profiler/xprofiler#248 or #11
Closed

升级到 egg v4 的 esm 模式后，qps 数据丢失 #10

fengmk2 opened this issue Mar 9, 2025 · 3 comments · Fixed by X-Profiler/xprofiler#248 or #11
Assignees
@fengmk2
Labels
bug Something isn't working

Comments

@fengmk2
Copy link
Member

fengmk2 commented Mar 9, 2025

Image
@fengmk2 fengmk2 added the bug Something isn't working label Mar 9, 2025
@fengmk2 fengmk2 self-assigned this Mar 9, 2025
@fengmk2
Copy link
Member Author

fengmk2 commented Mar 9, 2025 •
edited
Loading

https://github.com/X-Profiler/xprofiler/blob/master/patch/http.js#L79
patch 的是 commonjs 的 module，需要支持一下 esm

Image

@fengmk2
Copy link
Member Author

fengmk2 commented Mar 9, 2025

Image

可解 https://nodejs.org/docs/latest/api/diagnostics_channel.html#http

fengmk2 added a commit to X-Profiler/xprofiler that referenced this issue Mar 9, 2025
@fengmk2
feat: support monitor http server request by diagnostics_channel
1270982 
Usage:

```js
XPROFILER_PATCH_HTTP_WITH_DIAGNOSTICS_CHANNEL=YES npm start
```

closes X-Profiler/egg-xtransit#10
@fengmk2 fengmk2 mentioned this issue Mar 9, 2025
Merged
@fengmk2
Copy link
Member Author

fengmk2 commented Mar 9, 2025 •
edited
Loading

egg 需要在 config 中提供一个属性告诉插件目前 app 是 esm 模式
eggjs/egg#5402

@fengmk2 fengmk2 mentioned this issue Mar 9, 2025
Open
fengmk2 pushed a commit to X-Profiler/xprofiler that referenced this issue Mar 10, 2025
@semantic-release-bot
Release 3.0.0
1706ac4 
[skip ci]

## [3.0.0](v2.6.1...v3.0.0) (2025-03-10)

### ⚠ BREAKING CHANGES

* drop Node.js < 18.19.0 support

closes X-Profiler/egg-xtransit#10

### Features

* monitor http server request by diagnostics_channel ([#248](#248)) ([293abe8](293abe8))
fengmk2 added a commit that referenced this issue Mar 10, 2025
@fengmk2
feat: use xprofiler@3
25394e7 
BREAKING CHANGE: drop Node.js < 18.19.0 support

closes #10
@fengmk2 fengmk2 mentioned this issue Mar 10, 2025
Merged
fengmk2 added a commit that referenced this issue Mar 10, 2025
@fengmk2
feat: use xprofiler@3 (#11)
19aba98 
BREAKING CHANGE: drop Node.js < 18.19.0 support

closes #10
fengmk2 pushed a commit that referenced this issue Mar 10, 2025
@semantic-release-bot
Release 3.0.0
5c77c48 
[skip ci]

## [3.0.0](v2.0.0...v3.0.0) (2025-03-10)

### ⚠ BREAKING CHANGES

* drop Node.js < 18.19.0 support

closes #10

### Features

* use xprofiler@3 ([#11](#11)) ([19aba98](19aba98))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@fengmk2