Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward feature RPC #1436

Closed
godexsoft opened this issue May 29, 2024 · 0 comments · Fixed by #1440
Closed

Forward feature RPC #1436

godexsoft opened this issue May 29, 2024 · 0 comments · Fixed by #1440
Assignees
@godexsoft
Labels
compatibility enhancement New feature or request
Milestone
2.2

Comments

@godexsoft
Copy link
Collaborator

godexsoft commented May 29, 2024 •
edited
Loading

Summary

In #1131 we are going to implement a Clio-native feature API. However, this can't be done until XRPLF/rippled#5026 is merged and it does not look it's going to make it into libXRPL 2.2.0.
For the time being, let's forward feature instead.
@godexsoft godexsoft added the enhancement New feature or request label May 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio May 29, 2024
@godexsoft godexsoft changed the title Forward feature Forward feature RPC May 29, 2024
@godexsoft godexsoft self-assigned this May 30, 2024
@godexsoft godexsoft mentioned this issue May 31, 2024
Merged
@godexsoft godexsoft added this to the 2.2 milestone May 31, 2024
kuznetsss added a commit that referenced this issue Jun 11, 2024
@godexsoft @kuznetsss
Forward feature RPC (#1440)
42c970a 
Fixes #1436 

This is a temporary implementation of the `feature` RPC that will always
return `noPermission` iff `vetoed` is set.
If `vetoed` isn't specified, Clio will always forward the request to
`rippled` instead.

In the future, #1131 will implement a Clio-native `feature` RPC. This
requires specific support from `libxrpl` side and that is not going to
be available till at least 2.2.1, hence the temporary forwarding.

It would be great to review the error message and code so that we pick
the right one from the start.

Co-authored-by: Sergey Kuznetsov <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Jun 11, 2024
kuznetsss added a commit that referenced this issue Jun 18, 2024
@godexsoft @kuznetsss
Forward feature RPC (#1440)
6462323 
Fixes #1436 

This is a temporary implementation of the `feature` RPC that will always
return `noPermission` iff `vetoed` is set.
If `vetoed` isn't specified, Clio will always forward the request to
`rippled` instead.

In the future, #1131 will implement a Clio-native `feature` RPC. This
requires specific support from `libxrpl` side and that is not going to
be available till at least 2.2.1, hence the temporary forwarding.

It would be great to review the error message and code so that we pick
the right one from the start.

Co-authored-by: Sergey Kuznetsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godexsoft godexsoft

Labels
compatibility enhancement New feature or request
Projects
Clio
Status: ✅ Merged
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Forward feature RPC godexsoft/clio
1 participant
@godexsoft