Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deep freeze feature (XLS-77d) #5187

Merged
merged 54 commits into from
Jan 31, 2025
Merged

Add deep freeze feature (XLS-77d) #5187

merged 54 commits into from
Jan 31, 2025

Conversation

vvysokikh1
Copy link
Collaborator

@vvysokikh1 vvysokikh1 commented Nov 11, 2024 •
edited
Loading

High Level Overview of Change

This PR implements Deep Freeze feature described in this specification: XLS-77d

Context of Change

Added new flags and functionality allowing trust lines to be deep-frozen.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

ximinez
ximinez requested changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. I didn't go through all the tests.

ximinez
ximinez requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

gregtatcam
gregtatcam reviewed Dec 5, 2024
View reviewed changes
src/test/app/AMM_test.cpp Outdated
@@ -4397,6 +4397,48 @@ struct AMM_test : public jtx::AMMTest
0,
std::nullopt,
{features});

// Individually deep frozen account
if (features[featureDeepFreeze])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to repeat the code. Just add a conditional error:

auto const err = features[featureDeepFreeze] ? ter(tecPATH_DRY) : ter(tesSUCCESS)

And then use it in pay:

env(pay(alice, carol, USD(1)),
            path(~USD),
            sendmax(XRP(10)),
            txflags(tfNoRippleDirect | tfPartialPayment),
            err);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you shouldn't test here and other updated unit-tests if the feature is disabled because trust is going to fail. You need a separate test for disabled feature in SetTrust and also add to SetTrust tests for invalid combination of the flags. Also need to add OfferCreate and offer crossing, if not added yet, to Offer.

@vvysokikh1 vvysokikh1 changed the title [WIP] Deep freeze Deep freeze (#5187) Dec 10, 2024
gregtatcam
gregtatcam approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

ximinez
ximinez approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got some more changes coming, but everything looks good so far. I left one comment correction that isn't worth using "request changes"

@kennyzlei kennyzlei requested a review from ximinez January 30, 2025 22:31
@vvysokikh1 vvysokikh1 added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Amendment labels Jan 31, 2025
ximinez
ximinez approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my concerns are addressed

ximinez and others added 2 commits January 31, 2025 11:12
@ximinez
Merge branch 'develop' into deep_freeze
bd0e5cc
@vvysokikh1
Add deep freeze feature (XLS-77d)
024c16c 
 - spec: XRPLF/XRPL-Standards#220
 - implemented deep freeze spec to allow token issuers to prevent currency holders from being able to acquire more of these tokens.
 - in combination with normal freeze, deep freeze effectively prevents any balance trust line balance change of a currency holder (except direct issuer <-> holder payments).
 - added 2 new invariant checks to verify that deep freeze cannot be enacted without normal freeze and transfer is not frozen.
 - made some fixes to existing freeze handling.
@ximinez ximinez changed the title Deep freeze (#5187) Add deep freeze feature (XLS-77d) Jan 31, 2025
@ximinez ximinez merged commit 33e1c42 into XRPLF:develop Jan 31, 2025
22 checks passed
@ximinez ximinez mentioned this pull request Jan 31, 2025
Open
@PeterChen13579 PeterChen13579 mentioned this pull request Feb 5, 2025
Merged
This was referenced Feb 18, 2025
Closed
Closed
Closed
q73zhao pushed a commit that referenced this pull request Feb 24, 2025
@vvysokikh1 @ximinez
@HowardHinnant @q73zhao
Add deep freeze feature (XLS-77d) (#5187)
ffc88d7 
- spec: XRPLF/XRPL-Standards#220
- amendment: "DeepFreeze"
- implemented deep freeze spec to allow token issuers to prevent currency holders from being able to acquire more of these tokens.
- in combination with normal freeze, deep freeze effectively prevents any balance trust line balance change of a currency holder (except direct issuer <-> holder payments).
- added 2 new invariant checks to verify that deep freeze cannot be enacted without normal freeze and transfer is not frozen.
- made some fixes to existing freeze handling.

Co-authored-by: Ed Hennis <[email protected]>
Co-authored-by: Howard Hinnant <[email protected]>
This was referenced Feb 26, 2025
Closed
Merged
Closed
This was referenced Mar 5, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthomee bthomee bthomee left review comments

@ckeshava ckeshava ckeshava left review comments

@gregtatcam gregtatcam gregtatcam approved these changes

@ximinez ximinez ximinez approved these changes

@shawnxie999 shawnxie999 shawnxie999 approved these changes

Assignees
No one assigned
Labels
Amendment Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vvysokikh1 @shawnxie999 @gregtatcam @ximinez @bthomee @ckeshava @HowardHinnant