Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log proposals and validations. #5291

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Conversation

mtrippled
Copy link
Collaborator

.

High Level Overview of Change

Add detailed log messages for each validation and proposal received from the network.

Context of Change

New feature, adding log information. It mainly helps to correlate all the information about each message in a single place, including validators, which have multiple ways to be identified.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

New log entries for each validator and propsal at debug log level.

At debug level, grep for "NetworkOPs:DBG VALIDATION:" and "LedgerConsensus:DBG PROPOSAL"

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (dd5e655) to head (aa24229).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
include/xrpl/protocol/STValidation.h 0.0% 12 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 0.0% 9 Missing ⚠️
src/xrpld/consensus/ConsensusProposal.h 0.0% 7 Missing ⚠️
src/xrpld/app/consensus/RCLCxPeerPos.h 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5291     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          791     791             
  Lines        67976   68007     +31     
  Branches      8323    8349     +26     
=========================================
- Hits         52963   52961      -2     
- Misses       15013   15046     +33     
Files with missing lines Coverage Δ
src/xrpld/consensus/Consensus.h 89.0% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/consensus/RCLCxPeerPos.h 0.0% <0.0%> (ø)
src/xrpld/consensus/ConsensusProposal.h 87.9% <0.0%> (-10.4%) ⬇️
src/xrpld/app/misc/NetworkOPs.cpp 70.2% <0.0%> (-0.3%) ⬇️
include/xrpl/protocol/STValidation.h 69.5% <0.0%> (-17.7%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez added this to the 2.4.0 (Q1 2025) milestone Feb 14, 2025
@ximinez
Copy link
Collaborator

ximinez commented Feb 14, 2025

The clang-format job failed. I took the liberty of pushing the formatting fixes to the branch.

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming CI passes.

@mtrippled mtrippled added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 15, 2025
@mtrippled mtrippled force-pushed the log-consensus-messages branch from d105efd to 384d6a7 Compare February 15, 2025 01:04
@bthomee bthomee merged commit db0fad6 into XRPLF:develop Feb 15, 2025
21 of 24 checks passed
This was referenced Feb 18, 2025
q73zhao pushed a commit that referenced this pull request Feb 24, 2025
Adds detailed log messages for each validation and proposal received from the network.
This was referenced Feb 26, 2025
This was referenced Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants