-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log proposals and validations. #5291
Conversation
6a7fd54
to
e7dff04
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5291 +/- ##
=========================================
- Coverage 77.9% 77.9% -0.0%
=========================================
Files 791 791
Lines 67976 68007 +31
Branches 8323 8349 +26
=========================================
- Hits 52963 52961 -2
- Misses 15013 15046 +33
|
The clang-format job failed. I took the liberty of pushing the formatting fixes to the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming CI passes.
d105efd
to
384d6a7
Compare
Adds detailed log messages for each validation and proposal received from the network.
.
High Level Overview of Change
Add detailed log messages for each validation and proposal received from the network.
Context of Change
New feature, adding log information. It mainly helps to correlate all the information about each message in a single place, including validators, which have multiple ways to be identified.
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)New log entries for each validator and propsal at debug log level.
At debug level, grep for "NetworkOPs:DBG VALIDATION:" and "LedgerConsensus:DBG PROPOSAL"