Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revert peer port to 51235 #5299

Merged
merged 1 commit into from
Feb 19, 2025
Merged

docs: Revert peer port to 51235 #5299

merged 1 commit into from
Feb 19, 2025

Conversation

bthomee
Copy link
Collaborator

@bthomee bthomee commented Feb 19, 2025

High Level Overview of Change

Following up on #5290, this change sets the [port_peer] back to the legacy port 51235 rather than to the default port 2459.

Context of Change

The config is part of the binary and, unless an explicit config is passed, the behavior of the binary will unexpectedly be different when the port changes. As the binary would then use a different port, it would possibly make the server inaccessible depending on how routes and firewalls are configured. To err on the safe side, this change restores the port to the legacy value as it was, but still recommends using the default port for new deployments.

Type of Change

  • Documentation update

@bthomee bthomee requested review from legleux and ximinez February 19, 2025 20:17
@bthomee bthomee added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (01fc8f2) to head (6b71eb5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5299   +/-   ##
=======================================
  Coverage     77.9%   77.9%           
=======================================
  Files          791     791           
  Lines        68006   68006           
  Branches      8352    8347    -5     
=======================================
+ Hits         52962   52968    +6     
+ Misses       15044   15038    -6     

see 2 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bittersweet approval

@bthomee bthomee merged commit 844646d into develop Feb 19, 2025
24 checks passed
@bthomee bthomee deleted the bthomee/defaultport branch February 19, 2025 22:14
This was referenced Feb 21, 2025
q73zhao pushed a commit that referenced this pull request Feb 24, 2025
Reverts the [port_peer] back to the legacy port 51235 rather than to the default port 2459, to avoid potentially inconveniencing existing operators.
This was referenced Feb 26, 2025
This was referenced Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants