This repository was archived by the owner on Jun 23, 2022. It is now read-only.
feat(disk): reject write if disk space is insufficient #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
May 20, 2021
levy5307
reviewed
May 20, 2021
| @@ -75,23 +89,40 @@ unsigned dir_node::remove(const gpid &pid) | |||
| return iter->second.erase(pid); | |||
| } | |||
|
|
|||
| void dir_node::update_disk_stat() | |||
| void dir_node::update_disk_stat(bool &status_changed) | |||
There was a problem hiding this comment.
bool dir_node::update_disk_stat()
There was a problem hiding this comment.
I used to define function like your suggestion. If return false, it seems like update disk stat failed, so I pass status_chaned instead.
levy5307
reviewed
May 20, 2021
acelyc111
approved these changes
May 20, 2021
levy5307
approved these changes
May 28, 2021
hycdong
added
the
type/config-change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about disk protection when space is almost full. If one disk available space is below
disk_min_available_space_ratio, all replica on this disk will reject user write request. The disk status is updated periodically, when disk space is normal, user write request will be recovered.This pull request also adds related unit tests and dynamical configuration.