Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove les, light, faucet, lightchaindata #895

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Mar 6, 2025

Proposed changes

This PR removes:

  • package faucet
  • package les
  • package light
  • database lightchaindata

Ref:

TODO: remove pending logs in another PR

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • [ X Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan force-pushed the remove-les branch 3 times, most recently from 52ef29b to d977558 Compare March 6, 2025 11:02
@gzliudan gzliudan changed the title cmd, les: remove light client and faucet all: remove les, light, cmd/faucet, lightchaindata Mar 6, 2025
@gzliudan gzliudan changed the title all: remove les, light, cmd/faucet, lightchaindata [WIP] all: remove les, light, cmd/faucet, lightchaindata Mar 7, 2025
@gzliudan gzliudan changed the title [WIP] all: remove les, light, cmd/faucet, lightchaindata all: remove les, light, cmd/faucet, lightchaindata Mar 7, 2025
@gzliudan gzliudan changed the title all: remove les, light, cmd/faucet, lightchaindata [WIP] all: remove les, light, cmd/faucet, lightchaindata Mar 7, 2025
@gzliudan gzliudan force-pushed the remove-les branch 3 times, most recently from b1f9245 to f1321f8 Compare March 7, 2025 06:03
@gzliudan gzliudan changed the title [WIP] all: remove les, light, cmd/faucet, lightchaindata all: remove les, light, faucet, lightchaindata Mar 7, 2025
@benjamin202410
Copy link
Collaborator

nice!

@gzliudan gzliudan merged commit 3c80686 into XinFinOrg:dev-upgrade Mar 10, 2025
8 checks passed
@gzliudan gzliudan deleted the remove-les branch March 10, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants