Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pytest < 5.1.0 to fix the build on Python 3.5.0 #429

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

sjaensch
Copy link
Contributor

@sjaensch sjaensch commented Aug 19, 2019

I'm not 100% sure if this was the version that introduced the issue. Let's get a travis run to confirm.

Traceback from our build:

Traceback (most recent call last):
  File "/opt/python/3.5.0/lib/python3.5/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/python/3.5.0/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/pytest.py", line 6, in <module>
    from _pytest.assertion import register_assert_rewrite
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/assertion/__init__.py", line 6, in <module>
    from _pytest.assertion import rewrite
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/assertion/rewrite.py", line 24, in <module>
    from _pytest.assertion import util
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/assertion/util.py", line 5, in <module>
    import _pytest._code
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/_code/__init__.py", line 2, in <module>
    from .code import Code  # noqa
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/_code/code.py", line 388, in <module>
    class ExceptionInfo(Generic[_E]):
  File "/home/travis/build/Yelp/bravado/.tox/py35-default/lib/python3.5/site-packages/_pytest/_code/code.py", line 594, in ExceptionInfo
    def match(self, regexp: Union[str, Pattern]) -> bool:
  File "/opt/python/3.5.0/lib/python3.5/typing.py", line 534, in __getitem__
    dict(self.__dict__), parameters, _root=True)
  File "/opt/python/3.5.0/lib/python3.5/typing.py", line 491, in __new__
    for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
  File "/opt/python/3.5.0/lib/python3.5/typing.py", line 491, in <genexpr>
    for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
TypeError: issubclass() arg 1 must be a class

This issue is tracked upstream as pytest-dev/pytest#5751.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.749% when pulling 45cf98a on sjaensch:fix-build-python-3.5.0 into 3651534 on Yelp:master.

@sjaensch sjaensch requested a review from macisamuele August 19, 2019 07:41
@sjaensch sjaensch merged commit d412c5f into Yelp:master Aug 19, 2019
@sjaensch sjaensch deleted the fix-build-python-3.5.0 branch August 19, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants