Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tempo/time_signature at start with Score.clip method #61

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

Mintas
Copy link
Contributor

@Mintas Mintas commented Feb 25, 2025

for details see:
#60
and
#35 (comment)

@Yikai-Liao Yikai-Liao merged commit 617dd2d into Yikai-Liao:main Feb 28, 2025
1 of 7 checks passed
@Yikai-Liao
Copy link
Owner

Yikai-Liao commented Feb 28, 2025

events.filter([start, end, &sentinel](const T& event)

The compile error could be fixed like this. And I have fixed it in the main branch.

@Mintas
Copy link
Contributor Author

Mintas commented Feb 28, 2025

@Yikai-Liao Thank you!
I hope that will fix the issue =)

I'm not very aware of the current release process, when can we expect a new version of Symusic?

@Yikai-Liao
Copy link
Owner

I will release the new version today. Sorry for the waiting.

I have just partially refactor the midi parsing code, which leads to a nearly 60% acceleration. You could see the benchmark results here. Yikai-Liao/symusic-benchmark#1

And I have just finished cleaning the code and replace all the Chinese comments by English ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants