[optimization] support 8bit optims from bistandbytes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-r-r-o-w
reviewed
Dec 30, 2024
| @@ -79,6 +79,7 @@ class Args: | |||
|
|
|||
| # Optimizer arguments | |||
| optimizer: str = "adamw" | |||
There was a problem hiding this comment.
Could we instead allow specifying adamw-8bit-bnb here instead of use_8bit? Reason being TorchAO also supports 8-bit implementations so we could then use adamw-8bit-torchao in the future
a-r-r-o-w
reviewed
Dec 30, 2024
finetrainers/args.py
Outdated
| @@ -79,6 +79,7 @@ class Args: | |||
|
|
|||
| # Optimizer arguments | |||
| optimizer: str = "adamw" | |||
| use_8bit_bnb_bnb: bool = False | |||
|
Working fine with all the changes: https://wandb.ai/sayakpaul/finetrainers-ltxv/runs/kl9swsq8. I have added a note in the README too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137.
Run: https://wandb.ai/sayakpaul/finetrainers-ltxv/runs/7kk3xhkh