Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for LTXV #198

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Better defaults for LTXV #198

merged 2 commits into from
Jan 9, 2025

Conversation

a-r-r-o-w
Copy link
Owner

The major change is that we using logit_normal weighting as described in the paper. We did not know this detail beforehand when LTXV support was added leading to suboptimal loss.

@a-r-r-o-w a-r-r-o-w requested a review from sayakpaul January 9, 2025 05:26
Copy link
Collaborator

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We can continue to revisit these defaults (particularly these weighting schemes) as details become available to us. Currently, we have it for LTX (already done in this PR), Cog (done), and Mochi-1 (through their finetuner).

Perhaps, it might be nice to have a check with the Hunyuan folks about this.

@a-r-r-o-w a-r-r-o-w merged commit 6716ccf into main Jan 9, 2025
1 check passed
@a-r-r-o-w a-r-r-o-w deleted the better-defaults-ltx branch January 9, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants