Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the checkpoint dir bug in get_intermediate_ckpt_path #207

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix the checkpoint dir bug in get_intermediate_ckpt_path #207

merged 1 commit into from
Jan 10, 2025

Conversation

Awcrr
Copy link
Contributor

@Awcrr Awcrr commented Jan 10, 2025

Currently, the checkpoint dirs scanned only have the folder names not full paths. So, delete_files won't delete anything if output_dir is any non-empty path. Just a very simple fix to make checkpointing_limit work robustly.

a-r-r-o-w
a-r-r-o-w approved these changes Jan 10, 2025
View reviewed changes
Copy link
Owner

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤗

Looks like this slipped through untested. We'll add some minimal testing to ensure it works as expected soon

@a-r-r-o-w a-r-r-o-w merged commit b340913 into a-r-r-o-w:main Jan 10, 2025
1 check passed
@Awcrr Awcrr deleted the bugfix/checkpointing_limit branch January 10, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Awcrr @a-r-r-o-w