OcApfsLib: Always load JumpStart APFS directly #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vit9696
approved these changes
Jan 18, 2024
|
Thank you. Now it finaly booting. |
Thank you for the feedback, and for reporting this issue. |
mikebeaton
force-pushed
the
js-apfs-direct
branch
from
859a8fb to
60aad2a
Compare
apfs.efi has W^X errors which require fixup for strict loaders, however we were only passing the post-sanitised image to OC-wrapped platform loader, therefore the wrapper in ImageLoader.c cannot detect that it is an Apple signed binary which should be fixed up.
mikebeaton
force-pushed
the
js-apfs-direct
branch
from
60aad2a to
b259283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apfs.efi has W^X errors which require fixup for strict loaders, however we were only passing the post-sanitised image to OC-wrapped platform loader, therefore the wrapper in ImageLoader.c cannot detect that it is an Apple signed binary which should be fixed up.
Fixes issue reported here: acidanthera/bugtracker#2363 (comment)