Support both python 2 and 3 #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-strings are python 3 only. This commit uses .format() instead which works on both python 2 and 3. The shebang remains python3 as that's preferred.
|
Where do we need Python 2? Transition to Python 3 was intended. |
|
I had worked with a user recently who was intending to download 10.7 on a machine currently running Vista - which they were unable to install python 3 to. The changes in this PR don't affect python 3's functionality - but don't exclude python 2 support. |
|
Not sure we want to support this really. The change makes the code less readable. Sorry. |
|
Not a problem. Thank you for looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f-strings are python 3 only. This commit uses .format() instead which works on both python 2 and 3. The shebang remains python3 as that's preferred.