AppleModels: Move model code G3QD from MBP115 to MBP113 #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @Macschrauber.
Looks like the model code was in the wrong file:
http://support-sp.apple.com/sp/index?page=cpuspec&cc=G3QD is "MacBook Pro (Retina, 15-inch, Mid 2014)" which looks like a MacBookPro11,3 https://everymac.com/ultimate-mac-lookup/?search_keywords=MacBookPro11%2C3
Also macserial was previously producing 'WARN: Invalid year 2014 for model MacBookPro11,5' for this model code.
I am not 100% sure if any remaining matching changes need to be made anywhere, or if this is good to go.