Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change imports for acryl-datahub v1.0.0 compatibility #173

Merged
merged 2 commits into from
Mar 15, 2025
Merged

fix: Change imports for acryl-datahub v1.0.0 compatibility #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6685cc7
fix: Change imports for acryl-datahub v1.0.0 compatibility
asikowitz Mar 15, 2025
712b12b
remove siblings from yaml, not supported
asikowitz Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datahub-actions/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_long_description():
return description


acryl_datahub_min_version = os.environ.get("ACRYL_DATAHUB_MIN_VERSION") or "0.13.3.6rc1"
acryl_datahub_min_version = os.environ.get("ACRYL_DATAHUB_MIN_VERSION") or "1.0.0"

base_requirements = {
f"acryl-datahub[datahub-kafka]>={acryl_datahub_min_version}",
Expand Down
3 changes: 2 additions & 1 deletion datahub-actions/src/datahub_actions/plugin/action/propagation/propagation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
import datahub.metadata.schema_classes as models
from datahub.configuration.common import ConfigModel
from datahub.emitter.mce_builder import make_schema_field_urn
from datahub.ingestion.graph.client import DataHubGraph, SearchFilterRule
from datahub.ingestion.graph.client import DataHubGraph
from datahub.ingestion.graph.filters import SearchFilterRule

Check warning on line 26 in datahub-actions/src/datahub_actions/plugin/action/propagation/propagation_utils.py

View check run for this annotation

Codecov / codecov/patch

datahub-actions/src/datahub_actions/plugin/action/propagation/propagation_utils.py#L25-L26 

Added lines #L25 - L26 were not covered by tests
from datahub.metadata.schema_classes import MetadataAttributionClass
from datahub.utilities.str_enum import StrEnum
from datahub.utilities.urns.urn import Urn, guess_entity_type
Expand Down
3 changes: 0 additions & 3 deletions smoke-test/tests/actions/doc_propagation/resources/datasets_for_cycles_template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,3 @@
file: tests/actions/doc_propagation/resources/user_clicks.avsc
downstreams:
- urn:li:dataset:(urn:li:dataPlatform:hive,{{ test_id }}.user.clicks_2,PROD)
siblings:
- urn: urn:li:dataset:(urn:li:dataPlatform:events,{{ test_id }}.ClickEvent,PROD)
primary: true
Loading