Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual environment rebrand - readme updates #6006

Merged

Conversation

lkfortuna
Copy link
Contributor

Description

This update to the readme files adds a table of contents, organizes info by clearly define sections, bring to the forefront the image support policies, and adds an FAQ section.

It also updates any mentions of virtual environments to runner images.

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@actions actions locked and limited conversation to collaborators Aug 2, 2022
@miketimofeev
Copy link
Contributor

@lkfortuna should we remove this doc as the readme now includes everything?
https://github.com/actions/virtual-environments/blob/main/docs/software-and-images-guidelines.md

@lkfortuna
Copy link
Contributor Author

@lkfortuna should we remove this doc as the readme now includes everything? https://github.com/actions/virtual-environments/blob/main/docs/software-and-images-guidelines.md

@miketimofeev Yes, agreed I will add to this PR

Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 couple comments but nice update!

@lkfortuna lkfortuna requested review from samvantran, miketimofeev and Steve-Glass and removed request for miketimofeev August 5, 2022 18:08
Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind but i pushed to your branch to fix the linter errors @lkfortuna

@lkfortuna lkfortuna merged commit ce8db94 into actions:main Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants