Fix compatibility with Silicon Labs boards #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Silicon Labs core moved to use ArduinoCore-API which has a native 'BitOrder' definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We updated the Silicon Labs core to be based on Arduino-CoreAPI - which broke compatibility with Adafruit BusIO.
This PR makes the core compatible again. We now have a native definition for
BitOrderthanks to the CoreAPI, so a now unnecessary macro check has been removed.Limitations: none
Tests: tested on a few different Silicon Labs / Arduino boards with an ILI9341 and an ST7735 display
Let me know if there's any change needed or if you need more info on something!
All the best from your friends at Silicon Labs!